Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed assignment of parameter that no longer exits in SolarCollector example #1969

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented Feb 11, 2025

This closes #1968
It also adds the package to the CI tests.

@mwetter mwetter requested a review from jelgerjansen February 11, 2025 21:00
Copy link
Contributor

@jelgerjansen jelgerjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwetter thank you for noticing and fixing this! I noticed an obsolete whitespace in the revision history which I removed myself. The changes now look good to me!

@mwetter mwetter enabled auto-merge February 12, 2025 14:04
@mwetter mwetter merged commit 725c9be into master Feb 12, 2025
2 of 3 checks passed
@mwetter mwetter deleted the issue1968_solarCollectorExample branch February 12, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in solar collector example after refactoring
2 participants